New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: user management followup #8458
Conversation
WalkthroughWalkthroughThe recent updates introduce several enhancements and fixes across various components of the nc-gui package. Key changes include the addition of new computed properties and reactive variables in Changes
packages/nc-gui/composables/useUserSorts.tsBefore: // No previous declarations After: export function useUserSorts(roleType: 'Workspace' | 'Org' | 'Project' | 'Organization', sortsConfig: SortsConfig): number {
// Sorting logic for 'baseCount', 'workspaceCount', and 'memberCount'
} packages/nc-gui/lib/types.tsBefore: interface UsersSortType {
field: string;
direction: 'asc' | 'desc';
} After: interface UsersSortType {
field: 'memberCount' | 'baseCount' | 'workspaceCount' | string;
direction: 'asc' | 'desc';
} packages/nocodb/src/meta/migrations/v3/nc_o22_org_image.tsBefore: // No previous declarations After: export async function up(knex: Knex): Promise<void> {
await knex.schema.alterTable('ORG', (table) => {
table.string('image').alter();
});
}
export async function down(knex: Knex): Promise<void> {
await knex.schema.alterTable('ORG', (table) => {
table.dropColumn('image');
});
} --> Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (8)
- packages/nc-gui/components/dlg/InviteDlg.vue (10 hunks)
- packages/nc-gui/components/dlg/WorkspaceDelete.vue (1 hunks)
- packages/nc-gui/components/project/AccessSettings.vue (4 hunks)
- packages/nc-gui/components/workspace/CollaboratorsList.vue (7 hunks)
- packages/nc-gui/components/workspace/View.vue (1 hunks)
- packages/nc-gui/composables/useUserSorts.ts (1 hunks)
- packages/nc-gui/lib/types.ts (1 hunks)
- packages/nocodb/src/meta/migrations/v3/nc_o22_org_image.ts (1 hunks)
Files skipped from review as they are similar to previous changes (8)
- packages/nc-gui/components/dlg/InviteDlg.vue
- packages/nc-gui/components/dlg/WorkspaceDelete.vue
- packages/nc-gui/components/project/AccessSettings.vue
- packages/nc-gui/components/workspace/CollaboratorsList.vue
- packages/nc-gui/components/workspace/View.vue
- packages/nc-gui/composables/useUserSorts.ts
- packages/nc-gui/lib/types.ts
- packages/nocodb/src/meta/migrations/v3/nc_o22_org_image.ts
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (8)
- packages/nc-gui/components/dlg/InviteDlg.vue (10 hunks)
- packages/nc-gui/components/dlg/WorkspaceDelete.vue (1 hunks)
- packages/nc-gui/components/project/AccessSettings.vue (4 hunks)
- packages/nc-gui/components/workspace/CollaboratorsList.vue (7 hunks)
- packages/nc-gui/components/workspace/View.vue (1 hunks)
- packages/nc-gui/composables/useUserSorts.ts (1 hunks)
- packages/nc-gui/lib/types.ts (1 hunks)
- packages/nocodb/src/meta/migrations/v3/nc_o22_org_image.ts (1 hunks)
Files skipped from review as they are similar to previous changes (8)
- packages/nc-gui/components/dlg/InviteDlg.vue
- packages/nc-gui/components/dlg/WorkspaceDelete.vue
- packages/nc-gui/components/project/AccessSettings.vue
- packages/nc-gui/components/workspace/CollaboratorsList.vue
- packages/nc-gui/components/workspace/View.vue
- packages/nc-gui/composables/useUserSorts.ts
- packages/nc-gui/lib/types.ts
- packages/nocodb/src/meta/migrations/v3/nc_o22_org_image.ts
06aa3cf
to
d039549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/nc-gui/lang/en.json
is excluded by!**/*.json
Files selected for processing (7)
- packages/nc-gui/components/dlg/InviteDlg.vue (10 hunks)
- packages/nc-gui/components/dlg/WorkspaceDelete.vue (1 hunks)
- packages/nc-gui/components/project/AccessSettings.vue (4 hunks)
- packages/nc-gui/components/workspace/CollaboratorsList.vue (7 hunks)
- packages/nc-gui/components/workspace/View.vue (1 hunks)
- packages/nc-gui/composables/useUserSorts.ts (1 hunks)
- packages/nc-gui/lib/types.ts (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- packages/nc-gui/components/dlg/InviteDlg.vue
- packages/nc-gui/components/dlg/WorkspaceDelete.vue
- packages/nc-gui/components/project/AccessSettings.vue
- packages/nc-gui/components/workspace/CollaboratorsList.vue
- packages/nc-gui/components/workspace/View.vue
- packages/nc-gui/composables/useUserSorts.ts
- packages/nc-gui/lib/types.ts
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of