chore(experimental): Elaborate impls & non-trait impls #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljklein
requested changes
May 10, 2024
vezenovm
approved these changes
May 21, 2024
michaeljklein
approved these changes
May 21, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 21, 2024
…ic definition (noir-lang/noir#5041) feat: Implement turbofish operator (noir-lang/noir#3542) feat: add `as_witness` builtin function in order to constrain a witness to be equal to a variable (noir-lang/noir#4641) chore(experimental): Elaborate impls & non-trait impls (noir-lang/noir#5007) feat: add native rust implementation of schnorr signature verification (noir-lang/noir#5053) chore: Release Noir(0.30.0) (noir-lang/noir#4981)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 21, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(frontend): Call trait method with mut self from generic definition (noir-lang/noir#5041) feat: Implement turbofish operator (noir-lang/noir#3542) feat: add `as_witness` builtin function in order to constrain a witness to be equal to a variable (noir-lang/noir#4641) chore(experimental): Elaborate impls & non-trait impls (noir-lang/noir#5007) feat: add native rust implementation of schnorr signature verification (noir-lang/noir#5053) chore: Release Noir(0.30.0) (noir-lang/noir#4981) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch>
AztecBot
added a commit
that referenced
this pull request
May 21, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(frontend): Call trait method with mut self from generic definition (#5041) feat: Implement turbofish operator (#3542) feat: add `as_witness` builtin function in order to constrain a witness to be equal to a variable (#4641) chore(experimental): Elaborate impls & non-trait impls (#5007) feat: add native rust implementation of schnorr signature verification (#5053) chore: Release Noir(0.30.0) (#4981) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Working towards #4594
Summary*
Adds support for impls and trait impls to the elaborator.
This was somewhat satisfying to add since the existing code for this in
dc_crate.rsis very messy & long winded due to our current design of creating a newNameResolverfor every resolution. Keeping everything in the same elaborator and not needing to keep setting the interner, def maps, current crate, module, generics, append errors, etc saved many lines. I think this implementation is roughly half the size as a result.Additional Context
Still need types, type aliases, and globals after this. The pass is testable after that but is expected to fail the comptime tests at least. So I'll need to inline the comptime scanning pass in the elaborator as well. After that the pass is theoretically done but realistically there will be bugs to fix before we can make it the default.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.