-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add:On Linux system support open image in the Trash #1030
base: master
Are you sure you want to change the base?
Conversation
Hello @ZTFtrue , In case there is some issue with this code in the future, are you willing to help finding fixes/solutions? |
I'm willing to help finding fixes/solutions for this code in the future.
I don't think I have enough time to regarding other contributions, but if i
have free time, I will contribute code to nomacs.
…On Thu, Feb 22, 2024, 23:25 Daniel Novomeský ***@***.***> wrote:
Hello @ZTFtrue <https://github.com/ZTFtrue> ,
In case there is some issue with this code in the future, are you willing
to help finding fixes/solutions?
Do you have plans regarding other contributions to nomacs?
—
Reply to this email directly, view it on GitHub
<#1030 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHPP4X4SHQXDKOM3ES3BO3YU5PPTAVCNFSM6AAAAABDJS5BASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZGY4DGNRYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The link to trash items seems to be specific to the file manager instead of DE. I am on Arch with Sway WM and nautilus behaves differently from dolphin. Without your patch, Dolphin resolved the path for me when I attempted to open a trashed image with Nomacs, but Nautilus did not. Did you test with the default file managers for each DE mentioned? (Nautilus for Gnome, Dolphin for KDE, PCManFM for LXDE, and Thunar for XFCE4) |
I do not think so. I am not using Gnome. |
Dolphin will return the real path in some DE, But this feature will not deal with the real path. |
I'm sorry for sounding grumpy. Allow me to explain some of my thoughts. This feature feels like a "nice-to-have" for me. The problem can already be solved by restoring the trashed image, then nomacs can open it as a normal file. Note that I'm pretty biased since I have stopped using graphical file managers for a while. Adding support for opening items from the Trash of these file managers will couple nomacs to the handling of the URL schemes, fuse mount points, etc. GTK and KDE applications can understand these URLs because they use However, if we understand how these things work, we could probably also support other schemes like |
the first pr: #817 So I tested this feature in any DE and file manager I know so that it can support as many DE as possible. And, I found that there are only two situations, KDE environment and Gnome environment ( Maybe, because many desktop fork of GNOME). For other schemes, maybe we should develop new features. Add On:
|
This is what I am worrying about. If it is an implementation detail hidden behind some libraries, it could be changed, and nomacs would need to track and adapt to that change. Also, there might exist different situations that have not been considered in this PR. |
It is an odd feature that made its way into Linux file managers. I think it is the file manager's job to do the conversion to an ordinary path or symlink if it is going to expect anything to work with it, as KDE has done with dolphin. In which case there really isn't anything we need to do here. Dolphin, PCManFM (Xfce), Krusader all work. The GNOME/GVFS based ones are broken, perhaps by design. Nautilus will refuse to use nomacs even if it is the default application. Perhaps it sees the "%f" in the .desktop entry and says "you don't take a URL argument so it won't work -- sorry to break every application written in the last 30 years" The right way to support it is to get them to fix their code or else use their API in nomacs. If they can detect that a URL isn't supported then they can send a properly formatted path too. |
Add a feature on Linux system to support open image in the Trash. Support KDE, gnome, lxde-gtk3, xfce4.
Please check the following before submitting a pull request:
master
[checked]also have a look at our CONTRIBUTING.md