Fix incorrect crop tooltip when rotating #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nomacs#1071 The tooltip of the crop tool displays the center coordinates of the crop rectangle when it is rotated, however, the displayed value changes when we rotate around the center. The value is incorrect because the center is not properly translated before applying the rotation transform, which rotates around the origin. This patch calculates the coordinates to be displayed considering only the translation because rotation around the center should not change its position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1071
The tooltip of the crop tool displays the center coordinates of the crop rectangle when it is rotated, however, the displayed value changes when we rotate around the center.
The value is incorrect because the center is not properly translated before applying the rotation transform, which rotates around the origin. This patch calculates the coordinates to be displayed considering only the translation because rotation around the center should not change its position.