backend: do not crash if GGUF lacks general.architecture #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
manyoso
approved these changes
May 15, 2024
| @@ -786,12 +786,14 @@ const std::vector<LLModel::Token> &GPTJ::endTokens() const | |||
| } | |||
|
|
|||
| const char *get_arch_name(gguf_context *ctx_gguf) { | |||
| std::string arch_name; | |||
|
The other thing I'll say about this is that it encourages us to upstream our gptj support or drop it as the code copying is biting us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash when trying to start GPT4All with this non-llama.cpp GGUF installed.
Also, fix a crash when trying to load this model. Now it will display an "Unsupported file format" error in the UI.
Fixes #2292