Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dpi messages in Find dialog #15146

Closed
wants to merge 3 commits into from

Conversation

ozone10
Copy link
Contributor

@ozone10 ozone10 commented May 16, 2024

ref #14959

@ozone10
Copy link
Contributor Author

ozone10 commented May 16, 2024

@donho
the only thing missing is handling situation when goToCenter is invoked and

if (nppGUI._findWindowPos.bottom - nppGUI._findWindowPos.top != 0) // check height against 0 as a test of valid data from config

@donho
Copy link
Member

donho commented May 17, 2024

@ozone10

Almost...

After dragging from 200% screen to 100% screen:

image

@donho donho self-assigned this May 17, 2024
@donho
Copy link
Member

donho commented May 17, 2024

@ozone10

The bug of dragging from 200% screen to 100% screen still persist:
image

@ozone10
Copy link
Contributor Author

ozone10 commented May 17, 2024

@donho
I can not reproduce it so I am not sure what to do, also I am busy so I can't do thorough testing.

But could you provide some information. Which scale does your primary screen have?
Could you check if it does have some effect if you change primary screen?
Could you check how does less mode look and behave when dragging between screens?

@donho
Copy link
Member

donho commented May 18, 2024

@ozone10

But could you provide some information. Which scale does your primary screen have?

My main display's scale rate is 225%, external screen 100%

Just tested your latest commit, the issue seems gone - bravo!
The only remain issue is: while the 2nd Ctrl-F to make Find dialog display on the center of Notepad++ (225%) from the external screen (100%), Find dialog increases its width considerably - but you have mentioned "the only thing missing is handling situation when goToCenter is invoked..."

So let's merge this PR and treat the dialog width increasing issue in another PR.

Thank you!

@donho donho added the accepted label May 18, 2024
@donho donho closed this in bdc11a4 May 18, 2024
@ozone10 ozone10 deleted the DpiFindDlgDpiMsgs branch May 19, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants