feat: add invite team members nudge flow #5549

jainpawan21 · 2024-05-12T11:34:24Z

What changed? Why was the change needed?

In NV-3697, we want to use Novu workflow to send in-app and after some delay email. hubspot will be used to send email

Novu workflow :- Trigger -> in-app -> delay (24hr) -> email (with condition on webhook)

Flow:- User trigger the workflow, based on all conditions, in-app notification is sent to the user. After 24hr delay, workflow will create post request to webhookUrl (here webhookurl is new /invites/webhook API). If all conditions are satisfied, email is sent using hubspot.

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

linear · 2024-05-12T11:34:26Z

NV-3697 Invite team member nudge

netlify · 2024-05-12T11:34:40Z

✅ Deploy Preview for novu-design ready!

Name	Link
🔨 Latest commit	`fcc67f7`
🔍 Latest deploy log	https://app.netlify.com/sites/novu-design/deploys/66441f4eae045a0007293a7d
😎 Deploy Preview	https://deploy-preview-5549--novu-design.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-05-12T11:34:44Z

✅ Deploy Preview for dev-web-novu ready!

Name	Link
🔨 Latest commit	`fcc67f7`
🔍 Latest deploy log	https://app.netlify.com/sites/dev-web-novu/deploys/66441f4e9a7ca40008e15cef
😎 Deploy Preview	https://deploy-preview-5549--dev-web-novu.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apps/web/src/AppRoutes.tsx

apps/api/src/app/invites/usecases/invite-nudge-webhook/invite-nudge-usecase.ts

LetItRock · 2024-05-13T15:47:56Z

apps/api/src/app/events/usecases/parse-event-request/parse-event-request.usecase.ts

+    // check if this is first trigger
+    const notifications = await this.notificationRepository.count({
+      _organizationId: command.organizationId,
+      _environmentId: command.environmentId,
+    });


☑ chore: This will be super costly in terms of Mongo request, what we can do instead is take the first five or whatever number of notifications, and if there are then return.

Shall I add limit 1 ?

yes, but maybe better would be to do that with findOne

LetItRock · 2024-05-13T15:51:40Z

apps/api/src/app/events/usecases/parse-event-request/parse-event-request.usecase.ts

@@ -206,4 +221,68 @@ export class ParseEventRequest {

    return reservedVariables?.map((reservedVariable) => reservedVariable.type) || [];
  }
+
+  public async sendInAppNudgeForTeamMemberInvite(command: ParseEventRequestCommand) {


☑ chore: we don't need to do this for self-hosted

I have this condition before novu.trigger.
Wdyt? I should add similar conditions here

yes, but all code above it is not needed to be executed

LetItRock · 2024-05-13T15:52:28Z

apps/api/src/app/events/usecases/parse-event-request/parse-event-request.usecase.ts

@@ -206,4 +221,68 @@ export class ParseEventRequest {

    return reservedVariables?.map((reservedVariable) => reservedVariable.type) || [];
  }
+
+  public async sendInAppNudgeForTeamMemberInvite(command: ParseEventRequestCommand) {


🤓 nitpick (non-blocking): can we please also cover this logic with e2e tests?

LetItRock · 2024-05-13T15:54:16Z

apps/api/src/app/events/usecases/parse-event-request/parse-event-request.usecase.ts

@@ -206,4 +221,68 @@ export class ParseEventRequest {

    return reservedVariables?.map((reservedVariable) => reservedVariable.type) || [];
  }
+
+  public async sendInAppNudgeForTeamMemberInvite(command: ParseEventRequestCommand) {


☑ chore: and let's maybe also have this under the feature flag so we can disable if something is odd

Can I copy this line of code after changing the key
https://github.com/novuhq/novu/blob/NV-3697/apps/api/src/app/messages/usecases/get-messages/get-messages.usecase.ts#L61C5-L68C7 ?

yes, but with the new feature flag created in LD and as well as constant in the code

LetItRock · 2024-05-13T15:56:00Z

apps/api/src/app/invites/usecases/invite-nudge-webhook/invite-nudge-usecase.ts

+export class InviteNudgeWebhook {
+  constructor(private memberRepository: MemberRepository) {}
+
+  async execute(command: InviteNudgeWebhookCommand) {


☑ chore: same behind the feature flag

apps/api/src/app/events/usecases/parse-event-request/parse-event-request.usecase.ts

apps/api/src/app/widgets/usecases/mark-message-as/mark-message-as.usecase.ts

apps/web/src/AppRoutes.tsx

LetItRock · 2024-05-13T16:09:47Z

apps/web/src/pages/auth/components/LoginForm.tsx

+  const location = useLocation();
+  const state = location.state as { redirectTo?: { pathname?: string } };


🤓 nitpick (non-blocking): please put the appropriate types on the useLocation hook

apps/web/src/components/layout/RequiredAuth.tsx

antonjoel82

Left a couple notes on the web side!

antonjoel82 · 2024-05-13T19:49:23Z

apps/web/src/pages/auth/components/LoginForm.tsx

+export interface LocationState {
+  redirectTo: {
+    pathname: string;
+  };
+}
+


❓ question: Why are we defining the type for the return of the useLocation hook here?‏

☑ chore: We should avoid exporting a generic type from here as we may unknowingly cause circular dependencies‏

antonjoel82 · 2024-05-13T19:51:36Z

apps/web/src/pages/auth/components/LoginForm.tsx

+      if (state?.redirectTo?.pathname) {
+        navigate(state?.redirectTo?.pathname);
+      } else {
+        navigate(ROUTES.WORKFLOWS);
+      }


✏ suggestion: ‏

Suggested change

if (state?.redirectTo?.pathname) {

navigate(state?.redirectTo?.pathname);

} else {

navigate(ROUTES.WORKFLOWS);

}

navigate(state?.redirectTo?.pathname || ROUTES.WORKFLOWS);

* feat: add initial flow for invite nudge * feat: add route redirect * fix: add protonmail in cspell * fix: create const for payload key * fix: add state prop in navigate * fix: add user in analytics * fix: add webhook url variable * fix: pr comments, featute flag * fix: update hubspot list env variable * fix: failing test * fix: navigate to pathname * fix: decryption api key for webhook hmac

feat: add initial flow for invite nudge

8b1ade8

jainpawan21 requested a review from a team as a code owner May 12, 2024 11:34

github-actions bot added @novu/api @novu/web @novu/worker labels May 12, 2024

jainpawan21 requested review from davidsoderberg, LetItRock and djabarovgeorge May 12, 2024 11:47

feat: add route redirect

ff16153

jainpawan21 changed the title ~~feat: add initial flow for invite nudge~~ feat: add invite team members nudge flow May 13, 2024

jainpawan21 added 3 commits May 13, 2024 10:34

fix: add protonmail in cspell

8fc9aeb

Merge branch 'next' into NV-3697

f0bc323

fix: create const for payload key

6f9f860

github-actions bot added the @novu/shared label May 13, 2024

jainpawan21 added 3 commits May 13, 2024 15:31

fix: add state prop in navigate

0eaaefa

fix: add user in analytics

6b3caa0

fix: add webhook url variable

8baab8d

davidsoderberg reviewed May 13, 2024

View reviewed changes

apps/web/src/AppRoutes.tsx Show resolved Hide resolved

davidsoderberg reviewed May 13, 2024

View reviewed changes

apps/api/src/app/invites/usecases/invite-nudge-webhook/invite-nudge-usecase.ts Outdated Show resolved Hide resolved

LetItRock reviewed May 13, 2024

View reviewed changes

jainpawan21 added 3 commits May 13, 2024 22:50

fix: pr comments, featute flag

681dfad

fix: update hubspot list env variable

51b8730

fix: failing test

bdc6736

antonjoel82 reviewed May 13, 2024

View reviewed changes

fix: navigate to pathname

11b6c8a

LetItRock approved these changes May 14, 2024

View reviewed changes

Merge branch 'next' into NV-3697

c15aca2

github-actions bot removed the @novu/worker label May 14, 2024

jainpawan21 added 2 commits May 15, 2024 00:37

fix: decryption api key for webhook hmac

b518323

Merge branch 'next' into NV-3697

fcc67f7

jainpawan21 merged commit 17230b1 into next May 15, 2024
26 checks passed

jainpawan21 deleted the NV-3697 branch May 15, 2024 02:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add invite team members nudge flow #5549

feat: add invite team members nudge flow #5549

jainpawan21 commented May 12, 2024 •

edited

linear bot commented May 12, 2024

netlify bot commented May 12, 2024 •

edited

netlify bot commented May 12, 2024 •

edited

LetItRock May 13, 2024

jainpawan21 May 13, 2024

LetItRock May 13, 2024

LetItRock May 13, 2024

jainpawan21 May 13, 2024

LetItRock May 13, 2024

LetItRock May 13, 2024

LetItRock May 13, 2024

jainpawan21 May 13, 2024

LetItRock May 13, 2024

LetItRock May 13, 2024

LetItRock May 13, 2024

antonjoel82 left a comment

antonjoel82 May 13, 2024

antonjoel82 May 13, 2024

antonjoel82 May 13, 2024

		const location = useLocation();
		const state = location.state as { redirectTo?: { pathname?: string } };

feat: add invite team members nudge flow #5549

feat: add invite team members nudge flow #5549

Conversation

jainpawan21 commented May 12, 2024 • edited

What changed? Why was the change needed?

Screenshots

Related enterprise PR

Special notes for your reviewer

linear bot commented May 12, 2024

netlify bot commented May 12, 2024 • edited

✅ Deploy Preview for novu-design ready!

netlify bot commented May 12, 2024 • edited

✅ Deploy Preview for dev-web-novu ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antonjoel82 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jainpawan21 commented May 12, 2024 •

edited

netlify bot commented May 12, 2024 •

edited

netlify bot commented May 12, 2024 •

edited