Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor [@novu/client] : remove axios dependency and use fetch instead #5554

Merged
merged 8 commits into from
May 21, 2024

Conversation

BiswaViraj
Copy link
Contributor

@BiswaViraj BiswaViraj commented May 13, 2024

What changed? Why was the change needed?

  • Updated the HttpClient to use fetch
  • removed axios dependency
  • Moved the http-client to @novu/client

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented May 13, 2024

Copy link

netlify bot commented May 13, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 0d65ef4
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6648497966c07b0008411379
😎 Deploy Preview https://deploy-preview-5554--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 0d65ef4
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/664849780eccce000897ec1b
😎 Deploy Preview https://deploy-preview-5554--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BiswaViraj BiswaViraj requested a review from LetItRock May 13, 2024 12:00
@BiswaViraj BiswaViraj force-pushed the com-15-refactor-the-novuclient branch from 80d217b to 1f49b9b Compare May 16, 2024 07:43
packages/client/src/http-client/http-client.ts Outdated Show resolved Hide resolved
packages/client/src/http-client/http-client.ts Outdated Show resolved Hide resolved
packages/client/src/http-client/http-client.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@SokratisVidros SokratisVidros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@BiswaViraj BiswaViraj merged commit 06a7260 into next May 21, 2024
27 checks passed
@BiswaViraj BiswaViraj deleted the com-15-refactor-the-novuclient branch May 21, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants