Helmchart - add google bucket support #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiprafaj
requested review from
scopsy and
AliaksandrRyzhou
and removed request for
a team
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cliftonz
approved these changes
May 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
* add gcs bucket funcionality * remove unnecessary conditions .Values.localstack.existingSecret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
added possibility to use GCS bucket as an object storage
the app itself is capable of using those environment variables whilst the chart does not provide the option
see https://docs.novu.co/self-hosting-novu/object-storage
+ cleanup - remove unnecessary conditions on
.Values.localstack.existingSecret