Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace sign-in png with webp #5559

Merged
merged 1 commit into from
May 14, 2024
Merged

feat: Replace sign-in png with webp #5559

merged 1 commit into from
May 14, 2024

Conversation

antonjoel82
Copy link
Contributor

What changed? Why was the change needed?

  • Replace png with webp for sign-in background image!
  • 1.76MB --> 0.111MB so a quick win, and should help improve page load times!

Validation

There should be no visual difference in the login page in either color mode

  • Use the deploy preview to see the login page

Screenshots

Screenshot 2024-05-13 at 5 53 06 PM Screenshot 2024-05-13 at 5 52 47 PM

@antonjoel82 antonjoel82 requested a review from a team as a code owner May 14, 2024 00:55
Copy link

netlify bot commented May 14, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit ce29abe
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6642b69326e3cb0009936535
😎 Deploy Preview https://deploy-preview-5559--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit ce29abe
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/6642b69300cf920008737b7c
😎 Deploy Preview https://deploy-preview-5559--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@SokratisVidros SokratisVidros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@antonjoel82 antonjoel82 merged commit b664d61 into next May 14, 2024
25 checks passed
@antonjoel82 antonjoel82 deleted the signin-image branch May 14, 2024 14:50
github-actions bot pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants