Report position and set size for gridcells in treegrids #16504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See test results for failed build of commit 4b1bc354c2 |
LeonarddeR
reviewed
May 8, 2024
| @@ -121,6 +121,10 @@ def isDescendantOf(self, obj: "NVDAObjects.NVDAObject") -> bool: | |||
| return bool(res) | |||
|
|
|||
| def _get_positionInfo(self): | |||
| if self.role == controlTypes.Role.TABLECELL: | |||
| for anc in reversed(api.getFocusAncestors()): | |||
There was a problem hiding this comment.
This is definitely going to return wrong information when the table cell doesn't have focus, such as when using object navigation
I think you want to traverse the parents of the objects instead.
|
@LeonarddeR Thanks for a good catch; I could have really had egg on my face there. |
seanbudd
added
the
conceptApproved
|
Closing as more input is needed on the UX expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15818
Summary of the issue:
When navigating an ARIA treegrid's cells (as opposed to its rows), the position in set and set size are not supported.
Description of user facing changes
Position information are now reported.
Description of development approach
Modified
Ia2Web._get_positionInfoto return the closest ancestor treeitem's position information if the current focus is a gridcell.Testing strategy:
Manually tested with the APG Treegrid Email Inbox Example.
Known issues with pull request:
Level information is reported at the end of speech output when navigating by cell, unlike when navigating by row, where it is reported first if the level has changed.
Code Review Checklist: