Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: add collection api to retrieve record with filtered metadata #47

Closed
edwinkys opened this issue Mar 25, 2024 · 4 comments · Fixed by #86
Closed

FEAT: add collection api to retrieve record with filtered metadata #47

edwinkys opened this issue Mar 25, 2024 · 4 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request

Comments

@edwinkys
Copy link
Member

Purpose & use case

We should add an API for the Collection called maybe filter that takes in the condition and return a hash map of VectorID to Record. This filter API is useful for users who need to retrieve some of records which data match the provided condition.

@edwinkys edwinkys self-assigned this Mar 25, 2024
@edwinkys edwinkys added the enhancement New feature or request label Mar 25, 2024
@zzl-7
Copy link

zzl-7 commented Apr 26, 2024

Hi @edwinkys , is this issue open to contribution? If yes, is it possible to elaborate a bit on the ask here?
Thank you

@edwinkys
Copy link
Member Author

Hey, thank you for being interested in contributing. This issue is currently suspended.

Essentially, we want to create a method of collection, Collection.filter(...) where calling this allows users to retrieve vector records based on filter on the metadata.

pub fn filter(...) -> Result<HashMap<VectorID, Record>, Error>

The problem is that due to the flexible nature of the Metadata, I'm still thinking of what is the best way to solve this problem. I'd love to hear your thoughts tho 😁

@zzl-7
Copy link

zzl-7 commented May 1, 2024

@edwinkys Thanks for the response, I am still playing around with the repo in general so I think you would have better expertise in the direction of how filtering should go, as I dig around the code I will keep this ticket in mind, for now I don't have any thoughts on this
thanks

@edwinkys
Copy link
Member Author

edwinkys commented May 1, 2024

No problem! Take your time and please let me know if you need any help or have any questions. I'd be happy to help 😁

@edwinkys edwinkys linked a pull request May 18, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants