Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial filter implementation #86

Merged
merged 7 commits into from
May 23, 2024

Conversation

edwinkys
Copy link
Member

@edwinkys edwinkys commented May 18, 2024

Purpose

This PR adds Collection.filter operation to allow users perform deterministic query on the collection. This can be useful to retrive vector records based on their metadata.

Approach

This PR adds a Metadata.match_filter method that takes in another Metadata to test against.

Testing

  • I have tested this PR locally.
  • I added tests to cover my changes, if not applicable, I have added a reason why.

New filter test suites will be added.

Chore checklist

  • I have updated the documentation accordingly.
  • I have added comments to most of my code, particularly in hard-to-understand areas.

@edwinkys edwinkys added enhancement New feature or request in progress labels May 18, 2024
@edwinkys edwinkys self-assigned this May 18, 2024
@edwinkys edwinkys linked an issue May 18, 2024 that may be closed by this pull request
@edwinkys edwinkys force-pushed the 47-feat-filter-records-by-metadata branch from d776323 to 77bc5ef Compare May 18, 2024 23:11
@edwinkys edwinkys force-pushed the 47-feat-filter-records-by-metadata branch from 77bc5ef to 46e9659 Compare May 18, 2024 23:12
@edwinkys edwinkys marked this pull request as ready for review May 23, 2024 01:26
@edwinkys edwinkys merged commit 7797fcf into main May 23, 2024
4 checks passed
@edwinkys edwinkys deleted the 47-feat-filter-records-by-metadata branch May 23, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: add collection api to retrieve record with filtered metadata
1 participant