Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of NanoDet Model #902

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

deshpandeneeraj
Copy link

This PR introduces the integration of the NanoDet object detection model into the Sahi library.

Key Changes:

Addition of NanoDet Model: The NanoDet model has been added to the existing model library. This allows users to utilize NanoDet for object detection tasks, expanding Sahi's capabilities to include lightweight and efficient detection models.
Model Configuration and Weights: The necessary configuration files and pre-trained weights for the NanoDet model have been included. These configurations ensure optimal performance of the model within the Sahi environment.

Unit Tests: Unit tests have been added to ensure the correct functionality of the NanoDet model. These tests cover various scenarios to ensure robustness.

Cleanup :- Black, ISort, and Ruff has been run until no errors remain. Only a few Line too long for docstrings.

This integration broadens the range of models that Sahi supports, enabling users to leverage the NanoDet model's benefits, especially in scenarios where efficiency and model size are key considerations.

Please review the changes and provide any necessary feedback.

@deshpandeneeraj
Copy link
Author

@fcakyon could you review this if you have the time?

@fcakyon
Copy link
Collaborator

fcakyon commented Nov 5, 2023

Thanks for your great contribution @deshpandeneeraj !

If you could add some tests and a demo notebook as other model implementations, we would gladly accept this PR 👍

Copy link
Collaborator

@fcakyon fcakyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests and a demo notebook need to be added

@deshpandeneeraj
Copy link
Author

Yes will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants