lwt: auto detect Android from the compiler #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardoRFS
force-pushed
the
auto-detect-android
branch
from
f7b3e2d
to
5afa25c
Compare
EduardoRFS
commented
May 3, 2021
Comment on lines
-46
to
-41
| ["dune" "exec" "-p" name "src/unix/config/discover.exe" "--" "--save" | ||
| "--use-libev" "%{conf-libev:installed}%"] |
There was a problem hiding this comment.
This is a problem when cross compiling from Linux desktop to any non libev platform, like Android or iOS.
But it shouldn't be needed as it is enabled by default if it is not Windows or Android
https://github.com/ocsigen/lwt/blob/master/src/unix/config/discover.ml#L417
* this was a problem if compiling from Linux -> non libev platform
raphael-proust
force-pushed
the
auto-detect-android
branch
from
b095edc
to
74b119e
Compare
|
I've rebased on master to run against a more recent CI that's been fixed. This PR seems to have broken compilation on windows. Something about a missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At reason-mobile I try to keep all dune packages simple, by just adding
-x android.arm64on the CLI they ideally should build.This implies that the package itself should be able to discover the OS, which is not the case for LWT. Because otherwise we need an external build script to detect which OS should or should not add a flag.
This PR aims to fix that in making so that if no
android-targetis provided on the CLI, it tries to detect from the compiler.