Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .npmignore #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add .npmignore #82

wants to merge 1 commit into from

Conversation

AaronO
Copy link

@AaronO AaronO commented Apr 5, 2014

Reducing npm install size from ~3MB to ~64KB.

This has no negative side effects whatsoever and simply speeds up lunr download.

It's not an essential optimization, but it's small and easy.

Reducing nom install size from ~3MB to ~64KB
@AaronO
Copy link
Author

AaronO commented Apr 5, 2014

PS: I'm working on adding lunr to gitbook (https://github.com/GitbookIO/gitbook). And I just thought that the install size was a bit excessive and decided to remove some unnecessary cruft.

Let me know if you have any questions

@olivernn
Copy link
Owner

Thats quite a drop in install size!

I'm actually a bit of a noob with npm, but wouldn't it still be good to have the tests, and potentially the build dir around? I'm just thinking about running npm test etc?

GitBook is really cool project by the way, nice work.

@@ -0,0 +1,18 @@
/build/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need leading slashes?

@KyleAMathews
Copy link

Given that people download from NPM over and over and very rarely edit, I'd say it's the right optimization to not include anything but what's necessary and if someone does want to make modifications and run tests, they can do a quick git clone (which they'd need to do anyways to make contributions). I use NPM for both my api and frontend so very much appreciate fast downloads :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants