Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed to mark the library as typed #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davep
Copy link

@davep davep commented Apr 25, 2024

Removes an error like this:

error: Skipping analyzing "ollama":
module is installed, but missing library stubs or py.typed marker  [import-untyped]

when running mypy over code that uses the library.

Removes an error like this:

    error: Skipping analyzing "ollama":
    module is installed, but missing library stubs or py.typed marker  [import-untyped]

when running mypy over code that uses the library.
@bpshaver
Copy link

@jmorganca Any updates on this? It is quite hard to tell who the maintainer of this project is.

@bpshaver
Copy link

I don't use poetry but I would be very surprised if it doesn't automatically include py.typed in the distribution package.

@davep
Copy link
Author

davep commented Apr 30, 2024

@bpshaver You may be right, but I remember us needing to do this to convince Poetry to include it when building Textual; perhaps that's changed in the last year or so?

@davep
Copy link
Author

davep commented Apr 30, 2024

Just did a test build without the include and it does look like it does include it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants