-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ubi): add exception handler for SeekError #852
Conversation
My understanding is that if a What did you observe ? Was it a truncated image or the PEB is wrong ? |
PEB size is correct. I'm observing |
1df65a9
to
f6f8daa
Compare
54d5641
to
ec69171
Compare
ec69171
to
789dd3c
Compare
I think the changes are fine, and could be merged. I somewhat miss some means of test, that shows that it is working as intended. Another potential problem I was thinking on is, when the Would a minimal size check in |
789dd3c
to
de47659
Compare
@e3krisztian integration tests files demonstrating the behavior have been added by @mucoze
Minimal size checks are usually arbitrary and not super useful IMO. As you said, failing case is not a big issue as it would fail at extraction time. |
Truncated UBI images can lead to SeekError being raised. We now handle that situation gracefully.
… reads. Corrupt samples require the '-w' option so that we can actually extract content.
de47659
to
9143144
Compare
This check is needed to exit the loop when the end of the file is reached.