Avoid database queries on sourcediff component #15813
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danidoni
force-pushed
the
avoid-database-queries-on-sourcediff-component
branch
4 times, most recently
from
fdcd59c
to
797e246
Compare
danidoni
force-pushed
the
avoid-database-queries-on-sourcediff-component
branch
3 times, most recently
from
b9fa2fa
to
47db0c6
Compare
danidoni
force-pushed
the
avoid-database-queries-on-sourcediff-component
branch
from
47db0c6
to
0218d06
Compare
danidoni
force-pushed
the
avoid-database-queries-on-sourcediff-component
branch
2 times, most recently
from
44c7490
to
0218d06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewComponents recommends you run your database queries outside of the component.
This PR extracts the database queries outside the SourcediffComponent.
Depends on #15794