[backend] mkosi: publish images to per-arch subdirectory #15823
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluca
changed the title
bluca
force-pushed
the
mkosi_arch_publish
branch
from
02c0849
to
1e7b2db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15823 +/- ##
==========================================
+ Coverage 85.99% 86.07% +0.08%
==========================================
Files 794 793 -1
Lines 26072 26020 -52
==========================================
- Hits 22421 22398 -23
+ Misses 3651 3622 -29 |
Images do not have the architecture in the name, so an image recipe building for multiple architectures would have clashing filenames.
bluca
force-pushed
the
mkosi_arch_publish
branch
from
1e7b2db
to
716ff45
Compare
|
FYI: https://build.opensuse.org/project/show/home:bluca:mkosi has example packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images do not have the architecture in the name, so an image recipe building for multiple architectures would have clashing filenames, which means a single mkosi image build cannot currently enable multiple architectures. Change the publisher so that if we detect that we are publishing mkosi artifacts, they are stored in a per-architecture sub-folder.