New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring SCMWebhook away #15956

Draft

hennevogel wants to merge 35 commits into openSUSE:master from hennevogel:refactoring/scm_webhook

Member

hennevogel commented Apr 10, 2024

No description provided.

github-actions bot added the Frontend label

hennevogel marked this pull request as draft

April 10, 2024 10:17

hennevogel force-pushed the refactoring/scm_webhook branch 2 times, most recently from b848e29 to d9d43cb Compare

April 10, 2024 13:57

krauselukas force-pushed the refactoring/scm_webhook branch 4 times, most recently from 167b33c to 0d9c7ab Compare

April 11, 2024 12:59

hennevogel commented

View reviewed changes

src/api/app/models/concerns/workflow_run_payload.rb Outdated Show resolved Hide resolved

Member Author

hennevogel commented Apr 11, 2024

Merge SCMWebhook into WorkflowRun (L)

krauselukas force-pushed the refactoring/scm_webhook branch from a4f308b to c21a8a2 Compare

April 11, 2024 14:41

hennevogel commented

View reviewed changes

src/api/app/models/gitea_payload/pull_request.rb Show resolved Hide resolved

krauselukas force-pushed the refactoring/scm_webhook branch from c21a8a2 to 0c123d2 Compare

April 11, 2024 15:10

hennevogel commented

View reviewed changes

src/api/app/models/concerns/workflow_run_gitlab_payload.rb Outdated Show resolved Hide resolved

hennevogel commented

View reviewed changes

src/api/app/models/concerns/workflow_run_gitea_payload.rb Outdated Show resolved Hide resolved

hennevogel commented

View reviewed changes

src/api/app/models/concerns/workflow_run_gitea_payload.rb Outdated Show resolved Hide resolved

hennevogel commented

View reviewed changes

src/api/app/models/concerns/workflow_run_github_payload.rb Show resolved Hide resolved

krauselukas force-pushed the refactoring/scm_webhook branch from 0c123d2 to 77e681a Compare

April 11, 2024 15:24

hennevogel commented

View reviewed changes

src/api/app/models/concerns/workflow_run_gitlab_payload.rb

@@ @@ -43,6 +43,10 @@ def gitlab_target_branch @@
                   payload[:after] # for a tag push event
                 end
+                def gitlab_object_kind

Member Author

hennevogel Apr 11, 2024 •

edited

This makes little sense as it's not universal and it's just always merge_request when we use it...

krauselukas force-pushed the refactoring/scm_webhook branch 2 times, most recently from ce4dfbb to 940a867 Compare

April 12, 2024 12:47

hennevogel force-pushed the refactoring/scm_webhook branch 5 times, most recently from 1737385 to 70217b1 Compare

April 12, 2024 14:56

hennevogel added 4 commits

April 19, 2024 16:58


          Make SCMWebhook a concern

637128d

to be used in WorkflowRun.


          Stop tracking SCMWebhook initialization

2d26f5b

We are going to refactor SCMWebhook away...


          Stop "validating" this concern

804fe05

This will be something for TriggerWorkflowController


          Include WorkflowRunPayload concern

40ff3ab

so we can ask WorkflowRun everything we could ask SCMWebhook before...

hennevogel and others added 29 commits

April 19, 2024 16:58


          Introduces WorkflowRun.api_endpoint

fe66ff0


          Split WorkflowRun payload concern SCM specific

98ce3a7

We basically only need the SCM unspecific method public. The rest
can be private and in SCM specific concerns.


          Method to fetch the commit sha from the payload

e1c9887


          Set request_body variable

13c3fbf


          Choose commit_sha based on scm event

ea83733


          Add source_repository_full_name to workflow run payload concerns

c2a58a7


          Add target_repository_full_name to workflow run payload concerns

1f21e65


          Add commit_sha to gitea workflow run payload concern

67aa615


           Add pr_number to workflow run payload concerns


          Stop using SCMWebhook

e0346e9

Everything it was able to do, WorkflowRun can do now...


          Stop using TriggerControllerService::SCMExtractor

044f561

We don't need SCMWebhook anymore...


          Add checkout_http_url to workflow run payload concerns

76e27e9


          Add tag_name to workflow run payload concerns

276dc85


          Remove callback to extract_scm_webhook

cb83cc3

This method got removed.


          Add target_branch to workflow run payload concerns

c338782


          FIXUP: Remove last occurence of `@workflow_run.payload.fetch(:target_…

11bc8e0

…repository_full_name)`


          Add object_kind to workflow run gitlab payload concern


          Use hook_action over payload[:action]

646f79c


          Remove  TriggerControllerService::SCMExtractor class

24e92e2


          Split up and move scm vendor specific payload helper methods

d54552a


          Make workflow run payload concerns a module instead of class

ca0afe0


          Add more validations to WorkflowRun

22624d6


          Validate WorkflowRun.request_payload is JSON

c9d32a0


          Introduces WorkflowRun.supported_event? and .supported_action?

5960e91

To be able to ask if we are going to run for this or not.


          Make use of all the new WorkflowRun validations

7f69340


          Remove scm_webhook_spec and scm_extractor_spec

ce9ec3a


          Remove scm extractor related payload classes

a8fe063


          Remove scm webhook validator and spec

a52fab8


          Regernerate database_consistency todo

68287e5

hennevogel force-pushed the refactoring/scm_webhook branch from b4656e1 to 68287e5 Compare

April 19, 2024 14:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment