Make returned parameters consistent with its call in POST /source?cmd=branch

[eduardoj]

Instead of renaming the parameters (that would be an incompatible change), add elements with the names the parameters will take in the next version.

Before

> curl -H 'Content-Type: application/xml' -u Admin:opensuse -X POST "http://localhost:3000/source?cmd=branch&project=home:Admin&package=hello_world&target_project=home:Admin:branches&target_package=hello_world"
<status code="ok">
  <summary>Ok</summary>
  <data name="targetproject">home:Admin:branches</data>
  <data name="targetpackage">hello_world</data>
  <data name="sourceproject">home:Admin</data>
  <data name="sourcepackage">hello_world</data>
</status>

After

> curl -H 'Content-Type: application/xml' -u Admin:opensuse -X POST "http://localhost:3000/source?cmd=branch&project=home:Admin&package=hello_world&target_project=home:Admin:branches&target_package=hello_world"
<status code="ok">
  <summary>Ok</summary>
  <data name="target_project">home:Admin:branches</data>
  <data name="target_package">hello_world</data>
  <data name="project">home:Admin</data>
  <data name="package">hello_world</data>
  <data name="targetproject">home:Admin:branches</data>
  <data name="targetpackage">hello_world</data>
  <data name="sourceproject">home:Admin</data>
  <data name="sourcepackage">hello_world</data>
</status>

Fixes #16027.

[adrianschroeter]

That is an incompatible change, we can do that for 3.0, but not atm.

[adrianschroeter]

no reject button, so request changes

[adrianschroeter]

in theory, you could add the "new" elements, so data would be duplicated until 3.0. But IMHO a bit cringe and confusing.

[eduardoj]

in theory, you could add the "new" elements, so data would be duplicated until 3.0. But IMHO a bit cringe and confusing.

True. I can do that after fixing the tests. It seems fixing the tests will require not only modifying the tests, but also make other parts of the code understand the renamed parameters. Leaving it in WIP.

[eduardoj]

in theory, you could add the "new" elements, so data would be duplicated until 3.0. But IMHO a bit cringe and confusing.

I followed your suggestion. I didn't find any other way of making the return parameters work without provoking an incompatible change. Please take a look again.

[eduardoj]

@adrianschroeter, gently ping...

[adrianschroeter]

I hate it, but accept it ;)

However, please keep the tests in test/functional/maintenance_test.rb with old variable to ensure that we don't break api without noticing. You may add a comment there for the rename.

[eduardoj]

I hate it, but accept it ;)

🙂

However, please keep the tests in test/functional/maintenance_test.rb with old variable to ensure that we don't break api without noticing. You may add a comment there for the rename.

Done. Please take a look again.