Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open VideoCapture from memory buffer #25584

Open
wants to merge 10 commits into
base: 4.x
Choose a base branch
from
Open

Open VideoCapture from memory buffer #25584

wants to merge 10 commits into from
+559 −60

Conversation

dkurt
Copy link
Member

@dkurt dkurt commented May 14, 2024 •
edited

Pull Request Readiness Checklist

  • FFmpeg static
  • FFmpeg plugin
  • MSMF static
  • MSMF plugin
  • GStreamer
  • V4L2

resolves #24400

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dkurt
initial commit
023eeb5 
FFmpeg test
@dkurt dkurt force-pushed the videocapture_from_buffer branch from 2bd1a39 to 023eeb5 Compare May 14, 2024 12:42
@dkurt dkurt mentioned this pull request May 15, 2024
Open
@dkurt dkurt changed the title Open VideoCapture from memory buffer Open VideoCapture from memory buffer (FFmpeg backend only) May 15, 2024
@dkurt dkurt marked this pull request as ready for review May 15, 2024 14:50
@dkurt dkurt changed the title Open VideoCapture from memory buffer (FFmpeg backend only) Open VideoCapture from memory buffer May 16, 2024
@dkurt dkurt force-pushed the videocapture_from_buffer branch from 4dace6c to b71844d Compare May 16, 2024 19:24
opencv-alalek
opencv-alalek reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin support is necessary - it is mandatory for FFmpeg support on Windows.

modules/videoio/include/opencv2/videoio.hpp Outdated Show resolved Hide resolved
modules/videoio/include/opencv2/videoio.hpp Outdated Show resolved Hide resolved
@asmorkalov asmorkalov added this to the 4.11.0 milestone May 17, 2024
opencv-alalek
opencv-alalek reviewed May 19, 2024
View reviewed changes
modules/videoio/src/plugin_capture_api.hpp

@param filename File name or NULL to use camera_index or buffer instead
@param camera_index Camera index (used if filename == NULL and buffer == NULL)
@param buffer Memory buffer pointer (used if filename == NULL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to handle all 3 parameters for the source in a single method of API?
As we keep the previous version of the method, then we don't need to duplicate its functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

@asmorkalov asmorkalov Awaiting requested review from asmorkalov

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees
No one assigned
Labels
category: videoio feature RFC
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

VideoCapture add support for byte buffer
3 participants
@dkurt @opencv-alalek @asmorkalov