Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Configuration Display #274

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Steppenw01f
Copy link

fixes #180 and to some degree #204

This is an proposal of a solution for following issues:

  • Display of version intervals - Some CPEs have attributes like "versionStartIncluding" or "versionEndExcluding", that indicate which versions of the product are meant
  • Display of vulnerable component - All CPEs have an attribute "vulnerable", that indicates if they are the source of the vulnerability or only part of the configuration, which enables the vulnerability

Currently only the CPE-Strings are displayed (Example CVE-2022-0019)
grafik

This solution would be the proposed solution, that integrates both into the display of the Configurations.
grafik

Copy link
Member

@ncrocfer ncrocfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all sorry for this loooong time to review your PR ! I want to thank you for it, it's a very nice feature for OpenCVE 👍

But can you please tell me why you removed the CVE.ORG link part?

@ncrocfer
Copy link
Member

ncrocfer commented Aug 5, 2023

Arf, I'm sorry but you didn't revert your commit, you just move the block under the <hr /> tag:

image

Can you just remove the useless commit and add your changes?

Copy link
Member

@ncrocfer ncrocfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above.

@Steppenw01f
Copy link
Author

Thank you for the feedback.
Sorry, I will do my best 😅

@Steppenw01f Steppenw01f reopened this Aug 5, 2023
@Steppenw01f
Copy link
Author

Steppenw01f commented Aug 5, 2023

Ok, now the changes are committed and code style should be adequate, too.
Sorry for my troubles of reverting the commits 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add "From" and "Up to" within configuration for a specific vulnerability
2 participants