Sortable tables #306
Open
Sortable tables #306
+260
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add sort parameter to multi_value_parameter ~ move declaration of cls.order into build query to ensure reset of default parameters + add handling of sort parameter
…port url query parameter with multiple values
… state of the sorting + add _get_sort_parameter for links in the web view
+ add links in button style on table headers for sortable columns ~ change style of table header to be uniform
Steppenw01f
requested review from
ncrocfer,
ldurnez and
mferon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #74 and #210
This proposed solution contains following enhancements:
Remarks:
I am more of a backend developer, therefore might the code style of the cves.html not be the best.
Sorry for that.
If this draft is sufficient, I am more than happy about feedback.
Best regards,
Steppenw01f 😄