New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update constant.go #371
base: master
Are you sure you want to change the base?
Update constant.go #371
Conversation
fix: OpenELBDefaultKeepAliveImage
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: OAMchronicle The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: OAMchronicle The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It is recommended to use configmap to configure custom images. #285 |
What I mean is that there is a problem with this image。Why don't we modify the default image? |
It is not the best way to solve this problem. I think we should maintain a fork of the kube-keepalived-vip repository from https://github.com/aledbf/kube-keepalived-vip. If the image you built can solve your problem, you can first use configmap to modify the custom image. |
I started from https://github.com/aledbf/kube-keepalived-vip fork https://github.com/oamchronicle/kube-keepalived-vip . Partially modified the code and updated the dependent package version. |
Can you commit your changes to https://github.com/openelb/kube-keepalived-vip? |
Thanks! |
fix: #370