Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constant.go #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

OAMchronicle
Copy link

fix: #370

fix: OpenELBDefaultKeepAliveImage
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OAMchronicle
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OAMchronicle
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2023
@renyunkang
Copy link
Member

It is recommended to use configmap to configure custom images. #285

@OAMchronicle
Copy link
Author

What I mean is that there is a problem with this image。Why don't we modify the default image?

@renyunkang
Copy link
Member

It is not the best way to solve this problem. I think we should maintain a fork of the kube-keepalived-vip repository from https://github.com/aledbf/kube-keepalived-vip.

If the image you built can solve your problem, you can first use configmap to modify the custom image.

@OAMchronicle
Copy link
Author

I started from https://github.com/aledbf/kube-keepalived-vip fork https://github.com/oamchronicle/kube-keepalived-vip . Partially modified the code and updated the dependent package version.

@renyunkang
Copy link
Member

I started from https://github.com/aledbf/kube-keepalived-vip fork https://github.com/oamchronicle/kube-keepalived-vip . Partially modified the code and updated the dependent package version.

Can you commit your changes to https://github.com/openelb/kube-keepalived-vip?

@OAMchronicle
Copy link
Author

我从https://github.com/aledbf/kube-keepalived-vipforkhttps://github.com/oamchronicle/kube-keepalived-vip开始。部分修改了代码并更新了依赖包版本。

你能把修改提交到https://github.com/openelb/kube-keepalived-vip吗?

openelb/kube-keepalived-vip#1

@renyunkang
Copy link
Member

openelb/kube-keepalived-vip#1

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use IPVS vip mode Will generate a core file
3 participants