🐛 enhanced ud verification of cloneset #1608
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: acejilam <acejilam@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
+ Coverage 47.91% 49.23% +1.31%
==========================================
Files 162 164 +2
Lines 23491 18836 -4655
==========================================
- Hits 11256 9273 -1983
+ Misses 11014 8339 -2675
- Partials 1221 1224 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| allErrs = append(allErrs, field.Invalid(fldPath.Root(), template, fmt.Sprintf("Convert_v1_PodTemplateSpec_To_core_PodTemplateSpec failed: %v", err))) | ||
| return allErrs | ||
| } | ||
| allErrs = append(allErrs, appsvalidation.ValidatePodTemplateSpecForReplicaSet(coreTemplate, selector, 0, fldPath.Child("cloneSetTemplate", "spec", "template"), webhookutil.DefaultPodValidationOptions)...) |
There was a problem hiding this comment.
pkg/webhook/uniteddeployment/validating/uniteddeployment_validation.go:357:163: not enough arguments in call to appsvalidation.ValidatePodTemplateSpecForReplicaSet
| @@ -380,6 +395,14 @@ func validateDeployment(deployment *appsv1alpha1.DeploymentTemplateSpec, fldPath | |||
|
|
|||
| return allErrs | |||
| } | |||
| func validateCloneSet(cs *appsv1alpha1.CloneSetTemplateSpec, fldPath *field.Path) field.ErrorList { | |||
There was a problem hiding this comment.
The check is too simple, is it possible to refer to the cloneset validate webhook?
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews