Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to and from XContent to ClusterBlock and ClusterBlocks #13694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented May 15, 2024

Description

We need to upload the ClusterBlocks object to remote to enable the cluster state publication flow from remote. To do that we need to parse ClusterBlocks object to and from XContent.

Related Issues

Resolves #13692

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
    - [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 75ce997: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 215a135: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

Created a new issue for unrealted failing test org.opensearch.common.cache.stats.DefaultCacheStatsHolderTests.testConcurrentRemoval - #13695

Copy link
Contributor

❌ Gradle check result for 141b86b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

Failing test already identified as flaky
org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards - #10152

Copy link
Contributor

❌ Gradle check result for 141b86b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ee86138: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

✅ Gradle check result for ba27fd1: SUCCESS

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 83.92857% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 71.56%. Comparing base (b15cb0c) to head (ba27fd1).
Report is 323 commits behind head on main.

Files Patch % Lines
...ava/org/opensearch/cluster/block/ClusterBlock.java 79.62% 6 Missing and 5 partials ⚠️
...va/org/opensearch/cluster/block/ClusterBlocks.java 87.71% 1 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13694      +/-   ##
============================================
+ Coverage     71.42%   71.56%   +0.14%     
- Complexity    59978    61136    +1158     
============================================
  Files          4985     5059      +74     
  Lines        282275   287628    +5353     
  Branches      40946    41671     +725     
============================================
+ Hits         201603   205829    +4226     
- Misses        63999    64761     +762     
- Partials      16673    17038     +365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request skip-changelog
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Remote Cluster State] Add toXContent and fromXContent for ClusterBlocks
1 participant