[DerivedField] Support DerivedField object type and integration with Mapper #13720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhmaurya
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
enhancement
rishabhmaurya
added
skip-changelog
and removed
enhancement
github-actions
bot
added
enhancement
|
❌ Gradle check result for 0af215e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 51b813e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rishabhmaurya
force-pushed
the
df-object-type
branch
from
51b813e
to
4779e9c
Compare
|
❌ Gradle check result for 4779e9c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rishabhmaurya
force-pushed
the
df-object-type
branch
from
4779e9c
to
dedfe13
Compare
|
❌ Gradle check result for f204de0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
reviewed
Jun 4, 2024
server/src/main/java/org/opensearch/common/settings/ClusterSettings.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/DefaultDerivedFieldResolver.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/DerivedFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/DefaultDerivedFieldResolver.java
Show resolved
Hide resolved
* ValueFetcher for DerivedField of object type to parse and fetch nested fields. * DerivedFieldResolver to resolve DerivedField type on the fly. * Introduction of new support types - text, float. * Use index analyzer for derived fields set in index settings. * Support of derived fields from query string * Unit tests Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
rishabhmaurya
force-pushed
the
df-object-type
branch
from
f204de0
to
4baf532
Compare
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
|
❌ Gradle check result for 4baf532: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…rivedFieldQuery Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
|
❕ Gradle check result for 1d79fa8: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❌ Gradle check result for 6c1ff16: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
msfroh
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 9, 2024
…Mapper (#13720) * Support DerivedField object type * ValueFetcher for DerivedField of object type to parse and fetch nested fields. * DerivedFieldResolver to resolve DerivedField type on the fly. * Introduction of new support types - text, float. * Use index analyzer for derived fields set in index settings. * Support of derived fields from query string * Unit tests Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Derived field object type properties to also support Object as a value Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Index and cluster setting to control derived fields Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Fix test Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Fixed missing javadoc Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Fix the rewrite issue when profile is set as true Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Address PR comments Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Address PR comments Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Use conjuction query with filter on source_indexed_field query and DerivedFieldQuery Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * support source_indexed_field for non-object type derived fields Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename source_indexed_field to prefilter_field Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 9da6170) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support DerivedField object type and integration with Mapper and DerivedField query
DerivedFieldResolverFactoryto decide betweenNoOpandDefaultimplementation.text,floatandobject.source_indexed_field,properties,format,ignore_malformedintroduced in [DerivedField] object type support in mappings and new settings for derived field #13717 to make them functional.index.query.derived_field.enabledandsearch.derived_field.enabledrespectively, to enable/disable feature on dynamically.PR diff will reduce once preceding PRs are merged - #13592 and #13717
Related Issues
Resolves #13715
#13592
Check List
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.