Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consume query level cpu and memory usage in query insights #13739

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

consume query level cpu and memory usage in query insights #13739

wants to merge 3 commits into from

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented May 17, 2024 •
edited

Description

This is a follow up on https://github.com/opensearch-project/OpenSearch/pull/13172/files#diff-916410426108bbd0b06952c34490ca05c7a2a78c1c10f7af28e88ead23a70f24 to consume query level cpu and memory usage in query insights

Related Issues

#12399

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 80c4615: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ansjcy ansjcy mentioned this pull request May 17, 2024
Open
30 tasks
@ansjcy ansjcy force-pushed the consume-resource-usages-in-query-insights branch from 80c4615 to 02bb39e Compare May 30, 2024 22:32
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 02bb39e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@deshsidd
Copy link
Contributor

deshsidd commented Jun 3, 2024

Looks good to me overall. Some minor comments and changelog also needed.

jainankitk
jainankitk reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments to improve the readability of the code!

...sights/src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java Outdated Show resolved Hide resolved
plugins/query-insights/src/main/java/org/opensearch/plugin/insights/rules/model/MetricType.java Show resolved Hide resolved
...sights/src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java Outdated Show resolved Hide resolved
@ansjcy ansjcy force-pushed the consume-resource-usages-in-query-insights branch from 02bb39e to 14294b1 Compare June 4, 2024 22:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

❌ Gradle check result for 14294b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ansjcy ansjcy force-pushed the consume-resource-usages-in-query-insights branch 2 times, most recently from 67074ca to f003f9a Compare June 6, 2024 00:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 67074ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for f003f9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ansjcy ansjcy mentioned this pull request Jun 6, 2024
Open
4 tasks
@ansjcy ansjcy force-pushed the consume-resource-usages-in-query-insights branch from f003f9a to aa9835b Compare June 6, 2024 22:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for aa9835b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ansjcy
consume query level cpu and memory usage in query insights
30465dd 
Signed-off-by: Chenyang Ji <cyji@amazon.com>
@ansjcy
handle failed requests metrics in query insights
0b18782 
Signed-off-by: Chenyang Ji <cyji@amazon.com>
@ansjcy ansjcy force-pushed the consume-resource-usages-in-query-insights branch from aa9835b to 2d19224 Compare June 7, 2024 18:29
@ansjcy ansjcy added v2.15.0 Issues and PRs related to version 2.15.0 backport 2.x Backport to 2.x branch labels Jun 7, 2024
@ansjcy ansjcy force-pushed the consume-resource-usages-in-query-insights branch from 2d19224 to fa2c127 Compare June 7, 2024 18:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 2d19224: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@deshsidd
Copy link
Contributor

deshsidd commented Jun 7, 2024

Thanks for the refactoring! LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for fa2c127: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ansjcy
refactor the code to make it more maintainable
46669df 
Signed-off-by: Chenyang Ji <cyji@amazon.com>
@ansjcy ansjcy force-pushed the consume-resource-usages-in-query-insights branch from fa2c127 to 46669df Compare June 7, 2024 19:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 46669df:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for fa2c127:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ansjcy ansjcy mentioned this pull request Jun 8, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankitk jainankitk jainankitk left review comments

@deshsidd deshsidd deshsidd approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch v2.15.0 Issues and PRs related to version 2.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansjcy @deshsidd @jainankitk