Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added dependabot, husky and lint-staged #227

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

adithyaakrishna
Copy link

Description:

  • Added depenabot.yml for auto package updates
  • Added husky and lint-staged for pre-commit hooks
  • Added engines to enforce Node v18.0.0 and above

Adithya Krishna and others added 7 commits August 23, 2023 06:53
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
openstatus-doc ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 2:16am

@vercel
Copy link

vercel bot commented Aug 23, 2023

@adithyaakrishna is attempting to deploy a commit to the OpenStatus Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@mxkaske
Copy link
Member

mxkaske commented Aug 24, 2023

Appreciate it! Thanks @adithyaakrishna. We will check it later the day. 🙌

@mxkaske
Copy link
Member

mxkaske commented Aug 26, 2023

Sorry @adithyaakrishna, I missed that one.
Thank you for providing this PR! 🚀

Personally, I am not a big fan of adding dependabot in a project under development as we will be spammed with new updates. I bet we will still need it. The addition of husky and lint-staged is great. 🔥

Thankfully you haven't developed conventional pre-commit commit-msg for @thibaultleouay. 🤣

@thibaultleouay
Copy link
Member

I'm not a huge fan of pre-commit hooks they are just slowing me down one my local dev, we have some github action doing the check IMO

Also when we had new dependancies exact should be the default :)

What's the advantage of dependabot over renovate ( I have used renovate in an other project )

@mxkaske
Copy link
Member

mxkaske commented Aug 27, 2023

Hey @adithyaakrishna, appreciate it a lot! We will merge it once needed! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants