Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] Change get_input_const_data_as return type from std::unique_ptr to ov::optional #24443

Merged
merged 5 commits into from May 17, 2024
Merged

[CORE] Change get_input_const_data_as return type from std::unique_ptr to ov::optional #24443

merged 5 commits into from May 17, 2024

Conversation

barnasm1
Copy link
Contributor

@barnasm1 barnasm1 commented May 9, 2024 •
edited by mlukasze

Details:

  • Return type replaced
  • Checked if binary size decreased.

Tickets:

@barnasm1 barnasm1 added the category: Core OpenVINO Core (aka ngraph) label May 9, 2024
@barnasm1 barnasm1 requested a review from praasz May 9, 2024 12:01
@barnasm1 barnasm1 self-assigned this May 9, 2024
@barnasm1 barnasm1 requested a review from a team as a code owner May 9, 2024 12:01
praasz
praasz requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@praasz praasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix issues in tests

src/core/shape_inference/include/utils.hpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/strided_slice_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/interpolate_shape_inference.hpp Outdated Show resolved Hide resolved
barnasm1 and others added 2 commits May 9, 2024 15:23
@barnasm1 @praasz
Apply suggestions from code review
b155cd6 
Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>
@barnasm1
pass axes by refference to optional
fe69deb
@barnasm1 barnasm1 requested a review from praasz May 13, 2024 07:25
t-jankowski
t-jankowski approved these changes May 15, 2024
View reviewed changes
src/core/shape_inference/include/utils.hpp Outdated Show resolved Hide resolved
src/core/shape_inference/include/utils.hpp Outdated Show resolved Hide resolved
@barnasm1 barnasm1 requested a review from t-jankowski May 16, 2024 12:06
@t-jankowski t-jankowski added this pull request to the merge queue May 17, 2024
Merged via the queue into openvinotoolkit:master with commit 2353fb7 May 17, 2024
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-jankowski t-jankowski t-jankowski approved these changes

@praasz praasz praasz approved these changes

Assignees

@barnasm1 barnasm1

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barnasm1 @t-jankowski @praasz