Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] the controller on edge node can not list same path but with different selector when edge node is offline #1963

Closed
windnod opened this issue Mar 4, 2024 · 2 comments
Labels

Comments

@windnod
Copy link

windnod commented Mar 4, 2024

What happened:
the CanCacheFor() method filters out requests with the same path but different selector, so the controller on edge node can not list same path but with different selector when edge node is offline.

What you expected to happen:
YurtHub is capable of correctly proxying requests that have the same path but different selectors when edge node is offline.

Anything else we need to know?:

Environment:

  • OpenYurt version:
  • Kubernetes version (use kubectl version):
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

others

/kind bug

@rambohe-ch
Copy link
Member

@windnod Thank you for raising the issue. the reason that yurthub can not support different list requests is:

  1. different list requests maybe get different responses from kube-apiserver, this means the latter response of list request will overwrite the previous response of another list request.
  2. list from cache will return all objects for this different list requests, i think this can not satisfy the needs for list request.

based on the above explanation, we can not solve this problem by modifying the CanCacheFor function.

and we have discussed this case in the community, and @JameKeal have raised a proposal to solve this problem, the proposal link is here: #1614

but i think @JameKeal maybe has not enough time to implement this proposal. If you are interested in this case, we can have a discussion on the community meeting.

Copy link

stale bot commented Jun 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 4, 2024
@stale stale bot closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants