Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure local proxy can handle requests with the same path but with different selector #1964

Closed
wants to merge 1 commit into from

Conversation

windnod
Copy link

@windnod windnod commented Mar 4, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

skip the check for the same path list requests, when the localproxy use the canCacheFor() method

Which issue(s) this PR fixes:

Fixes #1963

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 52.41%. Comparing base (c8778fc) to head (6938de3).
Report is 55 commits behind head on master.

Files Patch % Lines
pkg/yurthub/proxy/remote/loadbalancer.go 0.00% 2 Missing ⚠️
pkg/yurthub/proxy/local/local.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1964   +/-   ##
=======================================
  Coverage   52.41%   52.41%           
=======================================
  Files         173      173           
  Lines       21015    21015           
=======================================
  Hits        11014    11014           
  Misses       9051     9051           
  Partials      950      950           
Flag Coverage Δ
unittests 52.41% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

@windnod Thanks for posting pull request. I have commented the issue #1963 , and we need to have more discussion about this case before we merge this pull request. sorry to response you lately.

Copy link

stale bot commented Jun 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2024
@stale stale bot closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] the controller on edge node can not list same path but with different selector when edge node is offline
2 participants