Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: work on bumping KB #6514

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

wip: work on bumping KB #6514

wants to merge 17 commits into from

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Jul 25, 2023 •
edited

Things to do:

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

closes: #6571

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@varshaprasad96
Copy link
Member Author

/hold
Please hold from reviewing. A bunch of changes need to be done, work in progress.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@varshaprasad96 varshaprasad96 temporarily deployed to deploy July 25, 2023 19:00 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 temporarily deployed to deploy July 27, 2023 21:27 — with GitHub Actions Inactive
@varshaprasad96
Copy link
Member Author

Blocked by kubernetes-sigs/controller-runtime#2427

@varshaprasad96 varshaprasad96 mentioned this pull request Jul 27, 2023
Closed
@varshaprasad96 varshaprasad96 temporarily deployed to deploy August 14, 2023 14:41 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 temporarily deployed to deploy August 14, 2023 14:41 — with GitHub Actions Inactive
Neo2308
Neo2308 reviewed Aug 14, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
Neo2308
Neo2308 reviewed Aug 14, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@varshaprasad96
[Fix] Bumping versions of KB, C_R and other deps
4a13e17 
Bumping versions of dependencies for k8s 1.27

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@varshaprasad96
[fix] Fix olm and helm source code to use latest changes
8c14bf6 
This commit fixes most of the OLM client and helm controller
code to accomodate the changes made in controller-runtime.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@varshaprasad96
[fix] Fix dependency versions and ansible handler unit tests
de7d5e6 
This commit fixes some of the dependency versions which need
to be pinned specifically in the project to be able to run
successfully. It also fixes the handler code base in ansible.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@varshaprasad96
[fix] Fix breaking ansible changes
e42db41 
This commit is the first iteration towards fixing breaking changes in
ansible to bump k8s dependencies.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@Neo2308 Neo2308 mentioned this pull request Sep 7, 2023
Merged
@Neo2308
Copy link

Neo2308 commented Sep 7, 2023

@varshaprasad96 raised a PR to this branch with the fix for unit & sanity tests.

Need help on fixing the e2e tests.

@varshaprasad96 varshaprasad96 temporarily deployed to deploy September 11, 2023 15:06 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 temporarily deployed to deploy September 11, 2023 15:06 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 temporarily deployed to deploy September 11, 2023 15:06 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 temporarily deployed to deploy September 11, 2023 15:06 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 temporarily deployed to deploy September 11, 2023 15:06 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 temporarily deployed to deploy September 11, 2023 15:06 — with GitHub Actions Inactive
@varshaprasad96
Copy link
Member Author

@Neo2308 Thanks for the fix. Looking into the CI, it seems like the e2e tests are failing on the run packagemanifests tests for OLM. Before we start looking into it and figure out the issue, I'm wondering if it is even required. Packagemanifests have been deprecated for long, are not being used widely, since folks have moved to using operator bundles. So it should be fine to remove them. I've created a slack thread to confirm with other maintainers: https://kubernetes.slack.com/archives/C017UU45SHL/p1694445066414709

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Neo2308
Copy link

Neo2308 commented Sep 22, 2023

@varshaprasad96 did we hear back on the slack thread? I dont have access to this slack organisation.

@varshaprasad96
Copy link
Member Author

varshaprasad96 commented Sep 22, 2023 •
edited

@Neo2308 I have not received any reply on this. But to unblock for now, I'd say to proceed with removing tests for package manifests but ensure that run bundle works as expected. Those can be added back in, if there is any strong opinion against removing them during reviews.

@Neo2308
Copy link

Neo2308 commented Sep 23, 2023

@varshaprasad96 could you take this up since I am not sure what exactly needs to be removed?

@everettraven
Copy link
Contributor

/assign @oceanc80

@josvazg josvazg mentioned this pull request Sep 27, 2023
Closed
This was referenced Oct 2, 2023
Closed
Merged
acornett21 and others added 2 commits October 9, 2023 11:40
@acornett21
removing packagemanifest tests
172b7e6 
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@varshaprasad96
Merge pull request #205 from acornett21/bump/k8s-1.27
d573720 
removing packagemanifest tests
@oceanc80 oceanc80 mentioned this pull request Oct 18, 2023
Merged
@Neo2308
Copy link

Neo2308 commented Dec 11, 2023

@varshaprasad96 / @oceanc80 What are the next steps here? Is there something I can help with?
Considering that k8s 1.29 is scheduled to be released this week, we would be 3 versions behind the master.

@Neo2308
Copy link

Neo2308 commented Dec 30, 2023

@varshaprasad96 could we close this PR since its been covered in #6613 and available in https://github.com/operator-framework/operator-sdk/releases/tag/v1.33.0

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlanouette davidlanouette davidlanouette left review comments

@Neo2308 Neo2308 Neo2308 left review comments

@acornett21 acornett21 acornett21 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@oceanc80 oceanc80

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot make install after updating java-operator-plugins
8 participants
@varshaprasad96 @Neo2308 @openshift-merge-robot @everettraven @openshift-bot @davidlanouette @acornett21 @oceanc80