-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #14698: Add ability to generate X sample translation opportunities on local dev server for the contributor dashboard #20278
base: develop
Are you sure you want to change the base?
Conversation
Hi @amaanlari please assign the required reviewer(s) for this PR. Thanks! |
… Proceeds to ‘it’ Block or another 'it' block/spec Despite Failure in ‘beforeAll’ setup or any other failure in the intial specs. (oppia#20192) * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates
PTAL @StephenYu2018 @seanlip |
Unassigning @amaanlari since a re-review was requested. @amaanlari, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM for two codeowner files.
Assigning @kevintab95 for code owner reviews. Thanks! |
Unassigning @amaanlari since a re-review was requested. @amaanlari, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my remaining review comment. Then I'll approve the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unassigning @StephenYu2018 since they have already approved the PR. |
PTAL @kevintab95 |
Hi @amaanlari. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
PTAL @kevintab95 |
Unassigning @kevintab95 since they have already approved the PR. |
Hi @amaanlari, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
@amaanlari Please fix the failing tests and then we an merge this! |
PTAL @kevintab95 |
Unassigning @amaanlari since a re-review was requested. @amaanlari, please make sure you have addressed all review comments. Thanks! |
Overview
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
Successful.generation.of.exps.webm
non-admin.cannot.generate.webm
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers