-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #18384: Reusable carousel component for learner dashboard redesign #20306
base: develop
Are you sure you want to change the base?
Fix part of #18384: Reusable carousel component for learner dashboard redesign #20306
Conversation
Assigning @Nik-09 for the first pass review of this PR. Thanks! |
Hi @amyyeung17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
@Nik-09 PTAL |
Sorry @amyyeung17 for the delay. I will take a look tomorrow morning. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @amyyeung17 for the PR, I have added a few comments, PTAL.
Also sorry for the delayed review.
Thanks
@@ -41,6 +41,7 @@ export class LearnerTopicSummaryTileComponent implements OnInit { | |||
thumbnailBgColor!: string; | |||
openInNewWindow = false; | |||
@Input() redesignFeatureFlag!: boolean; | |||
@Input() last!: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very generic name, can you please help me to understand what does this mean?
@@ -34,6 +34,7 @@ import {StoryNode} from 'domain/story/story-node.model'; | |||
export class LessonCardComponent implements OnInit { | |||
@Input() story!: StorySummary | LearnerExplorationSummary | CollectionSummary; | |||
@Input() topic!: string; | |||
@Input() last!: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as prev comment
import {downgradeComponent} from '@angular/upgrade/static'; | ||
|
||
@Component({ | ||
selector: 'card-display', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the selector name oppia-card-display
to make the component consistent throughout the codebase?
Overview
This PR addresses part of the 3rd breakpoint of #18384, adding a new reusable carousel component.
Includes 3 new files:
Additional notes:
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
final-carousel.mov