Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Migration State #20318

Closed
wants to merge 1 commit into from
Closed

Angular Migration State #20318

wants to merge 1 commit into from

Conversation

robert0010
Copy link

  1. This PR refactors migration of the StateObjectFactory file to Angular from Refactor all migrated object factories to model.ts files in angular. #10700
  2. This PR performs, as requested in the issue, the migration of the Object Factories refactor in the "StateObjectFactory.ts" file, which is now "state-object.model.ts" (one of the steps described in its implementation). Imports no longer be required was removed and Factory was replaced by Model class in its overview. A class with ObjectFactory suffix was found but not modified due to the existence of its constructor. @Injectable was removed and the rest was commented out in the implementation.

Modified files:

  • StateObjectFactory.ts

This Issue fix is pure refactoring and no logic has been modified or added

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

This is a simple refactoring work. Since the code logic has not been modified there is no proof.

PR Pointers

@robert0010 robert0010 requested a review from a team as a code owner May 15, 2024 17:37
Copy link

oppiabot bot commented May 15, 2024

Hi @robert0010, can you complete the following:

  1. The body of this PR is missing the overview section, please update it to include the overview.
  2. The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided.
    Thanks!

Copy link

oppiabot bot commented May 15, 2024

Hi @robert0010 please assign the required reviewer(s) for this PR. Thanks!

Copy link

oppiabot bot commented May 22, 2024

Hi @robert0010, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label May 22, 2024
@oppiabot oppiabot bot closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant