Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - support environment variable for TF_VAR_private_key and TF_VAR_private_key_password #1693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Boulet-
Copy link

@Boulet- Boulet- commented Oct 27, 2022

When a Default value is defined, the DefaultFunc is ignored/not called. Use the second parameter of DefaultFunc to put the default value.

To reproduce the issue, try to do a plan using TF_VAR_private_key or OCI_PRIVATE_KEY instead of TF_VAR_private_key_path

…VAR_private_key_password

When a default value is defined, the DefaultFunc is ignored/not called
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 27, 2022
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@jotruon jotruon force-pushed the master branch 2 times, most recently from 32a2ef5 to 29d7f7c Compare October 27, 2022 21:00
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 28, 2022
@Boulet-
Copy link
Author

Boulet- commented Nov 8, 2022

@jotruon Any chance to have review for this one?
Thanks in advance

@jotruon
Copy link
Member

jotruon commented Nov 8, 2022

assign reviewer and testing for this PR

@Boulet-
Copy link
Author

Boulet- commented Nov 9, 2022

assign reviewer and testing for this PR

I don't think I'm allowed to do it or I didn't find how to do it (no button under/near reviewers)

@tf-oci-pub tf-oci-pub added the Pending Test Pending Test label for PRs label Jun 10, 2023
@tf-oci-pub
Copy link
Member

Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.

Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.

We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.

We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. Pending Test Pending Test label for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants