Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identity domain destruction by deactivating the identity domain before deletion #1782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

F21
Copy link

@F21 F21 commented Mar 1, 2023

The current implementation for deleting an identity domain attempts to call delete on it immediately. This will fail because an identity domain must be deactivated before it can be deleted. See API reference: https://docs.oracle.com/en-us/iaas/api/#/en/identity/20160918/Domain/DeleteDomain

This PR fixes the issue by deactivating the identity domain and waiting until it is marked as deactivated before attempting to delete it.

Closes #1781

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Mar 1, 2023
@F21 F21 force-pushed the fix-identity-domain-destruction branch 2 times, most recently from 4ceb46c to c826ae4 Compare March 10, 2023 02:13
@F21 F21 force-pushed the fix-identity-domain-destruction branch from c826ae4 to 3bef0c5 Compare March 15, 2023 21:57
@F21 F21 force-pushed the fix-identity-domain-destruction branch from 3bef0c5 to f8222f0 Compare March 31, 2023 03:46
@F21 F21 force-pushed the fix-identity-domain-destruction branch from f8222f0 to 509df0e Compare April 24, 2023 22:30
@F21 F21 force-pushed the fix-identity-domain-destruction branch from 509df0e to 1de8fed Compare May 25, 2023 22:36
@thpham
Copy link

thpham commented Jul 17, 2023

Can someone from Oracle can take this over even the PR contributor has not signed the OCA !?
This is blocking us. It could be very easy to re-submit the PR and being able to be reviewed/approved !

@F21
Copy link
Author

F21 commented Jul 17, 2023

@thpham, oracle has approved my OCA, but it seems they don't really accept external contributions for this project.

@F21 F21 force-pushed the fix-identity-domain-destruction branch from 1de8fed to 762cc89 Compare July 20, 2023 23:23
@F21 F21 force-pushed the fix-identity-domain-destruction branch from 762cc89 to bd53691 Compare August 4, 2023 05:17
@tf-oci-pub tf-oci-pub added the Pending Test Pending Test label for PRs label Aug 28, 2023
@tf-oci-pub
Copy link
Member

Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.

Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.

We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.

We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.

@F21 F21 force-pushed the fix-identity-domain-destruction branch from bd53691 to f807c08 Compare August 29, 2023 22:05
@F21 F21 force-pushed the fix-identity-domain-destruction branch from f807c08 to ea5aa29 Compare October 17, 2023 22:15
@F21 F21 force-pushed the fix-identity-domain-destruction branch from ea5aa29 to 979b5b0 Compare March 10, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. Pending Test Pending Test label for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting identity domain fails
3 participants