Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Modify Storage Path Fragment to use Progress Bar instead of Progress Dialog #7965

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arthur-GYT
Copy link
Contributor

All is in the title ^^.

@Arthur-GYT Arthur-GYT force-pushed the progress_dialog_depreciation branch 4 times, most recently from 4532599 to 7523c84 Compare April 21, 2024 09:44
@Arthur-GYT Arthur-GYT changed the title Modify Storage Path Fragment to use Progress Bar instead of Progress Dialog [android] Modify Storage Path Fragment to use Progress Bar instead of Progress Dialog Apr 21, 2024
@biodranik
Copy link
Member

What does this change improve? How it looks like?

@Arthur-GYT
Copy link
Contributor Author

Arthur-GYT commented Apr 21, 2024

@biodranik It's for this issue : #3629

And for the UI :

Screenshot_20240421-153436.png

@Jean-BaptisteC
Copy link
Member

When progress bar is shown, is it possible to select another storage?
Please use Material Linear progress indicator instead appcompat progress bar
Can you check similar dialog in bookmarks activity?

@Arthur-GYT
Copy link
Contributor Author

Arthur-GYT commented Apr 21, 2024

When progress bar is shown, is it possible to select another storage? Please use Material Linear progress indicator instead appcompat progress bar Can you check similar dialog in bookmarks activity?

In my tests, it's not possible to select another storage when progress bar is shown.

And for progress bar, it's fixed.

Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
@Arthur-GYT Arthur-GYT marked this pull request as draft April 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants