Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android-auto] Use compass and location data from car #8022

Merged
merged 1 commit into from May 16, 2024

Conversation

AndrewShkrob
Copy link
Member

#6974

Fix for #7416

#8015 needs to be merged first

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So if the car's compass is available, data will come from it, and if not, then a phone's compass will be used, correct? Is there a way to test it on the emulator?

@Jean-BaptisteC @rtsisyk is there also a way to test it on a real device?

@biodranik biodranik added this to the Needs alpha/beta testing milestone Apr 28, 2024
@AndrewShkrob
Copy link
Member Author

Is there a way to test it on the emulator?

Yes. It was described in the old PR.

@rtsisyk
Copy link
Contributor

rtsisyk commented Apr 29, 2024

Thanks for reworking #6974. I will test this on my real device. Let's target the next release June.

@rtsisyk
Copy link
Contributor

rtsisyk commented Apr 29, 2024

Signed version for testing on devices: https://play.google.com/apps/test/RQOeR78v0uA/ahAO29uNQqKyxo7BBjlop0I12Tfa3DMO6m0ShV5-c5PGGDABkpB3ksFJ8fomRYUWseP54LwJoUUMDPH8_gRkqqgT4z

  1. Open the Google Play Store app Google Play.
  2. Tap Menu Menu > Settings.
  3. In the “About” section, tap the Play Store version 7 times.
  4. After the Internal app sharing setting appears, tap the switch to turn on internal app sharing. Tap Turn on.

CC: @AndrewShkrob @Jean-BaptisteC

@biodranik
Copy link
Member

@rtsisyk did you tested it? Is it ready for release?

Copy link
Member

@Jean-BaptisteC Jean-BaptisteC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Pixel 6 - Android 14 + AA Emulator

@biodranik
Copy link
Member

@rtsisyk were you able to test it?

@rtsisyk
Copy link
Contributor

rtsisyk commented May 16, 2024

I've tested this change on real $69.99 Chinese hardware in my car today. I don't know whether my car radio has hardware sensors or not, but I haven't noticed a difference. Android Auto worked perfectly.

@rtsisyk
Copy link
Contributor

rtsisyk commented May 16, 2024

@AndrewShkrob could you please rebase this PR and I will push it.

Signed-off-by: Andrew Shkrob <andrew.shkrob.social@yandex.by>
@rtsisyk rtsisyk merged commit 2fdf424 into organicmaps:master May 16, 2024
6 checks passed
@rtsisyk
Copy link
Contributor

rtsisyk commented May 16, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AndroidAuto Android Auto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants