[ios] add default OSLog Logger for ios>14.0 to release #8040
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
biodranik
reviewed
Apr 30, 2024
|
|
||
| if #available(iOS 14.0, *), enableLoggingInRelease { | ||
| os.Logger.logger.log(level: OSLogLevelFromLogLevel(level), "\(formattedMessage, privacy: .public)") | ||
| } else if Logger.canLog(level) { | ||
| Logger.log(level, message: formattedMessage) |
There was a problem hiding this comment.
Does it make sense to also log into this logger on iOS 14+?
There was a problem hiding this comment.
We are using this logger for swift to pass it to the core logger. But there only 2 places where the logging from swift is used now.
I don't think that it's useful to duplicate logging messages. But of them will be visible in the debugger.
biodranik
reviewed
Apr 30, 2024
| @@ -27,18 +28,42 @@ func statusBarHeight() -> CGFloat { | |||
| return min(statusBarSize.height, statusBarSize.width) | |||
| } | |||
|
|
|||
| private let enableLoggingInRelease = true | |||
There was a problem hiding this comment.
In swift variables outside the types are already static. Compiler will warn if I add the satatic.
|
What is the current status here? @biodranik do you have any other comments? |
|
This PR creates a separate independent logger from our existing C++ logs engine which logs only a few specific cases (now only iCloud). It would be great to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging using the default OSLogger for ios>14.0 during the release.
This PR does not affect the core logging.