Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Folder refactoring #8094

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[data] Folder refactoring #8094

wants to merge 2 commits into from
+124 −236

Conversation

AndrewShkrob
Copy link
Member

Moved tests into a separate folder - test_data

  • gpx/
  • kml/
  • osm/
  • world_feed_integration_tests_data/
  • broken_bookmarks.kmb.test

I can't move minsk-pass.mwm to the test_data folder yet. It requires a lot of changes in the code.

Moved fonts into a separate folder:

  • 00_NotoNaskhArabic-Regular.ttf
  • 00_NotoSansThai-Regular.ttf
  • 00_NotoSerifDevanagari-Regular.ttf
  • 01_dejavusans.ttf
  • 02_droidsans-fallback.ttf
  • 03_jomolhari-id-a3d.ttf
  • 04_padauk.ttf
  • 05_khmeros.ttf
  • 06_code2000.ttf
  • 07_roboto_medium.ttf
  • fonts_blacklist.txt
  • fonts_whitelist.txt
  • unicode_blocks.txt

Changes tested on Desktop (MacOS), iPhone and Android

@AndrewShkrob AndrewShkrob requested review from biodranik and vng May 5, 2024 17:46
@AndrewShkrob AndrewShkrob requested a review from a team as a code owner May 5, 2024 17:46
AndrewShkrob
AndrewShkrob commented May 5, 2024
View reviewed changes
qt/CMakeLists.txt Outdated Show resolved Hide resolved
@AndrewShkrob
[data] Move test data into a separate folder
f8282bb 
Signed-off-by: Andrew Shkrob <andrew.shkrob.social@yandex.by>
@AndrewShkrob
[data] Move fonts into a separate folder
7c6805c 
Signed-off-by: Andrew Shkrob <andrew.shkrob.social@yandex.by>
rtsisyk
rtsisyk reviewed May 15, 2024
View reviewed changes
.gitignore
@@ -84,7 +84,7 @@ data/[0-9][0-9][0-9][0-9][0-9][0-9]
data/gps_track.dat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem does this PR solve?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mess in the data folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtsisyk rtsisyk rtsisyk left review comments

@biodranik biodranik Awaiting requested review from biodranik

@vng vng Awaiting requested review from vng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrewShkrob @rtsisyk