Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clang-tidying #8109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

biodranik
Copy link
Member

No description provided.

@biodranik biodranik requested a review from vng May 6, 2024 19:06
Copy link
Contributor

@rtsisyk rtsisyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Use constant base font height" and "minor clang-tidying" are two unrelated changes. The latter probably don't raise any questions and can be merged via a separate PR.

@biodranik biodranik force-pushed the ab-drape-use-constant-base-font-height branch from 23638ea to 1b5dc0e Compare May 16, 2024 22:16
Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik biodranik force-pushed the ab-drape-use-constant-base-font-height branch from 1b5dc0e to c72363d Compare May 19, 2024 21:26
@biodranik biodranik changed the title [drape] Use constant base font height and minor clang-tidying Minor clang-tidying May 19, 2024
@biodranik
Copy link
Member Author

@rtsisyk @vng PTAL, only minor tidying is left.

Copy link
Member

@vng vng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I find these changes strange. Yes, in terms of C++ some methods may be const, but not in terms of design logic.

How making const functions like Invalidate, SetXXX, AddXXX should help to understand the code better - IDK. I made a quick look and don't agree here.

@vng
Copy link
Member

vng commented May 20, 2024

This short example shows how we should filter all tidy stuff.

class Foo
{
    class Impl
    {
        int m_state;
    public:
        void ChangeState() { ++m_state; }
    };

    Impl * m_impl;

public:
    // Aha, const, oops.
    void ChangeState() const { m_impl->ChangeState(); }
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants