[core] Fix unused-parameter warnings #8110
Open
+320
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Shkrob <andrew.shkrob.social@yandex.by>
biodranik
reviewed
May 6, 2024
| @@ -142,15 +142,6 @@ set(SRC | |||
| validate_and_format_contacts.hpp | |||
| ) | |||
|
|
|||
| set(OTHER_FILES drules_struct.proto) | |||
| "$<$<CXX_COMPILER_ID:AppleClang,Clang>:-Wno-shorten-64-to-32> $<$<CXX_COMPILER_ID:GNU>:-Wno-deprecated-declarations>" | ||
| ) | ||
|
|
||
| file(COPY ${OTHER_FILES} DESTINATION ${CMAKE_BINARY_DIR}) |
Comment on lines
+104
to
+105
| NamesDataSource EditableMapObject::GetNamesDataSource(StringUtf8Multilang const & source, vector<int8_t> const &, | ||
| int8_t const) |
There was a problem hiding this comment.
cmon )
Suggested change
| NamesDataSource EditableMapObject::GetNamesDataSource(StringUtf8Multilang const & source, vector<int8_t> const &, | |
| int8_t const) | |
| NamesDataSource EditableMapObject::GetNamesDataSource(StringUtf8Multilang const & source, vector<int8_t> const &, int8_t const) |
| @@ -11,7 +11,7 @@ namespace downloader_tests | |||
|
|
|||
| class DownloaderStub : public storage::MapFilesDownloaderWithPing | |||
| { | |||
| virtual void Download(storage::QueuedCountry && queuedCountry) | |||
| void Download(storage::QueuedCountry &&) override | |||
| @@ -1,7 +1,6 @@ | |||
| # Flags for all | |||
| set(OMIM_WARNING_FLAGS | |||
| $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic> | |||
| $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wno-unused-parameter> # We have a lot of functions with unused parameters | |||
There was a problem hiding this comment.
What are the pros of enabling this warning? I see the following cons:
- Git blame is more complicated.
- Where parameter names are removed, they're not clear and the reader should guess to understand.
- Where parameter names are commented, it is not possible to comment large blocks of code with /* */ anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.