New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data] Refactor resources folder #8123
base: master
Are you sure you want to change the base?
[data] Refactor resources folder #8123
Conversation
2c294de
to
a1a5440
Compare
Signed-off-by: Andrew Shkrob <andrew.shkrob.social@yandex.by>
a1a5440
to
8e6bc06
Compare
@AndrewShkrob did you see this one? WDYT? #7264 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually its different:
128x32 for mdpi
512x128 for xxxhdpi
data/symbols-svg/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stuff in resources-svg
is very different from "symbols.png".
Icons from resources-svg
are used in apps' UI and AFAIK not directly, e.g. for android they have to be converted into vector drawable.
"symbols.png" are map icons (and other symbols) consumed by core and automatically generated via generate_symbols.sh
.
So I think it makes sense to keep their names different to avoid confusion.
Maybe just leave "resources-svg" as is or rename to e.g. "UI-icons-svg"...
So traffic arrows are different (compare mdpi to xxxhdpi).
|
Thanks for this PR, its a great companion to #7264! Please check #7264 (comment) |
Though I'm not sure it'll be a good idea to put them into |
@@ -15,7 +15,7 @@ stxxl.log | |||
screenlog.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What problem does this PR solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mess in the data folder
New folder structure
From
To
Moved
area-hatching.png
andtraffic-arrow.png
from{dpi}/{clear|dark}
tosymbols/default
folder as all these files are the same and not regenerated.Unfortunately, Xcode doesn't allow a
resources
folder in the root directory. I had to rename the folder fromresources
tosymbols
.More info: https://stackoverflow.com/questions/33993741/codesign-failed-with-exit-code-1-failing-to-build-copy-resources/40167588#40167588
I cannot place
resources-svg
insymbols/svg
due to another Xcode problem. It doesn't allow to have a reference folder and exclude one of the subfolders from the project.