sql: Avoid returning empty matches with regex_split #8083
+21
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smjert
force-pushed
the
stefano/improvement/regex-split-discard-empty
branch
from
8d5c7c3
to
de127f0
Compare
Smjert
force-pushed
the
stefano/improvement/regex-split-discard-empty
branch
from
de127f0
to
6190a09
Compare
Smjert
changed the title
| @@ -305,12 +305,12 @@ The following trig functions: `sin`, `cos`, `tan`, `cot`, `asin`, `acos`, `atan` | |||
|
|
|||
| osquery> .mode line | |||
|
|
|||
| osquery> select uid from users; | |||
| osquery> select uid from users; | |||
There was a problem hiding this comment.
Is this whitespace intentional?
There was a problem hiding this comment.
Yes, it's to force a linebreak, since if you check here https://osquery.readthedocs.io/en/latest/introduction/sql/#string-functions, the uid = 500 line is rendered on the same line of the query.
| EXPECT_EQ(d[0]["t1"], "foo"); | ||
| EXPECT_EQ(d[0]["t2"], "bar"); | ||
| EXPECT_EQ(d[0]["t3"], ""); | ||
| EXPECT_EQ(d[0]["t0"], "foo"); |
There was a problem hiding this comment.
This feels like a breaking change. And I have no idea what correct is in the larger world.
Though, I guess regex_split and split behave differently, and that's also confusing:
osquery> select split('/foo/bar', '/', 1), regex_split('/foo/bar', '/', 1);
+---------------------------+---------------------------------+
| split('/foo/bar', '/', 1) | regex_split('/foo/bar', '/', 1) |
+---------------------------+---------------------------------+
| bar | foo |
+---------------------------+---------------------------------+
Still, I worry about a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.