New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #2228: refine config directive token parse; #4042
base: develop
Are you sure you want to change the base?
issue #2228: refine config directive token parse; #4042
Conversation
349f5cd
to
f74a308
Compare
trunk/scripts/verify_confs.sh
Outdated
@@ -0,0 +1,37 @@ | |||
#!/bin/bash | |||
|
|||
TRUNK_DIR=$(dirname -- "${BASH_SOURCE[0]}")/../ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test file? Should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the var store the path of trunk
folder, the almost the source root of srs project, then doing the next steps.
run srs -t -c [conf file]
for every file inside ${TRUNK_DIR}/conf/*
.
@@ -223,7 +223,7 @@ VOID TEST(SampleTest, ContextTest) | |||
cache[0] = cid; | |||
} | |||
|
|||
MockProtectedBuffer::MockProtectedBuffer() : size_(0), data_(NULL), raw_memory_(NULL) | |||
MockProtectedBuffer::MockProtectedBuffer() : raw_memory_(NULL), size_(0), data_(NULL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just to fix a compiler warning: the init order should be the declare orders in the header file.
srs/trunk/src/utest/srs_utest.hpp
Lines 112 to 117 in 37f0faa
private: | |
char* raw_memory_; | |
public: | |
int size_; | |
// Should use this as data. | |
char* data_; |
39152ce
to
8b95506
Compare
make sure one directive token don't span more than two lines.
8b95506
to
99b0f64
Compare
make sure one directive token don't span more than two lines.
try to fix #2228